-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(syncers): refactor syncers #699
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
==========================================
- Coverage 88.50% 88.45% -0.06%
==========================================
Files 160 160
Lines 10919 10841 -78
Branches 1199 1189 -10
==========================================
- Hits 9664 9589 -75
+ Misses 1255 1252 -3 ☔ View full report in Codecov by Sentry. |
Refactor synchronizers:
This PR removes unnecessary inheritance from the synchronizers. Instead of creating multiple synchronizer classes through inheritance, we now use a single base synchronizer class.
Previously, each subclass was only providing a different synchronize function via the constructor, without adding any new methods or behavior. Since the base synchronizer class already takes a name, a cron pattern, and a synchronize function (which runs according to the cron pattern), the subclasses were redundant. This refactor simplifies the code by directly using the base class.
Additionally, this PR fixes a typo: "ocurred" → "occurred".