Clustering flag #151
Merged
Clustering flag #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyChristina
requested changes
Apr 29, 2024
| @@ -21,7 +21,16 @@ def analyze(projects, aggregated_data_filename, output_dir): | |||
| """ | |||
| logging.info('Calculating metrics on aggregated data..') | |||
| metrics = hlp.get_metrics_config() | |||
| metric_names = list(metrics.keys()) | |||
| metric_values = [] | |||
There was a problem hiding this comment.
I recommend renaming this (perhaps to metric_params) to distinguish from the variable we use later to store the results (which currently has the same name). It might also be more useful to make it a dict?
| @@ -21,7 +21,16 @@ def analyze(projects, aggregated_data_filename, output_dir): | |||
| """ | |||
| logging.info('Calculating metrics on aggregated data..') | |||
| metrics = hlp.get_metrics_config() | |||
| metric_names = list(metrics.keys()) | |||
| metric_values = [] | |||
| metric_names = [] | |||
There was a problem hiding this comment.
This variable is not really necessary now that we have the one defined above too. I would recommend removing this one and having f'{key}={val}' as the first item for the metric_values entries when there is an arg, and then accessing the names from there when needed
LadyChristina
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description
Adds a parameter in the configuration file that allows the user to enable/disable clustering.