Update execution parameter handling #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyChristina
requested changes
Jun 6, 2024
| try: | ||
| granularity = get_config_data()['granularity'] | ||
| if granularity: | ||
| if granularity in ['day', 'week', 'month', 'year']: |
There was a problem hiding this comment.
Not a big deal, but if we inlude None in this list we wouldn't need the outside if
There was a problem hiding this comment.
Also, before we used "all" instead of empty / None. I'm fine to keep the empty one but then some more docstring needs to be changed where it shows "all" as an option. Additionally, since "aggregate_by" was renamed to "granularity", it should be renamed everywhere (there are some helper functions that use it and haven't been renamed from what I can tell)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description
Remove all command line arguments and move all parameters to the config file. Also creates helper functions to retrieve the params. This makes it more consistent with the tokenomics analysis execution flow.