-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Loading status checks…
Merge #244: Typed value
5a5a4e2 refactor: Value constructors (Christian Lewe) a3fe129 refactor: Type-check Simplicity values (Christian Lewe) d58710a feat: Add word type constructors (Christian Lewe) 5483fec feat: Compute padding (Christian Lewe) d4e78a7 feat: Add BitCollector (Christian Lewe) 0be5b02 fix: Remove iterations counter (Christian Lewe) Pull request description: We need to encode values with padding on the Bit Machine. This encoding requires information about the type of the value. It turns out that universally typing all Simplicity values produces the smallest diff, and it is the safest API. This PR refactors the `Value` struct to include type information. I also have ideas for a `Word` struct that wraps values of the word type. Only these values are safe to use in word jets. I will leave this for a follow-up PR. ACKs for top commit: apoelstra: ACK 5a5a4e2 successfully ran local tests; nice! And does the API changes needed to later replace the `Value` internal representation with a flat bit array, which should greatly speed things up Tree-SHA512: 17343a5642946d486533b67e083f5b5dc891de9154dd492c479e7f03a031e6e2e2d4eda95a3d424e990647e0bf74dc885308d7ac9374afc30777c0e27b6156ca
Showing
26 changed files
with
519 additions
and
396 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.