Fix AMR #214
Merged
Fix AMR #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error was introduced in fac715d The error makes the AMR computation panic.
uncomputable
added a commit
to uncomputable/simfony
that referenced
this pull request
Apr 23, 2024
apoelstra
reviewed
Apr 23, 2024
src/bit_encoding/decode.rs
Outdated
| @@ -236,7 +236,7 @@ pub fn decode_expression<I: Iterator<Item = u8>, J: Jet>( | |||
| converted.push(new); | |||
| } | |||
|
|
|||
| converted[len - 1].get().map(Arc::clone) | |||
| converted[len - 1].get().cloned() | |||
There was a problem hiding this comment.
Aside from violating our MSRV, this code is objectively worse because it hides the fact that the clone is merely an arc clone.
If clippy is really complaining about this, you probably need to file separate bugs about (a) the lint not respecting MSRV and (b) the lint being stupid.
There was a problem hiding this comment.
I was struggling to write .cloned() in a way that includes Arc. The lint is stupid and I disabled it now.
The CMR value of this variant is never used. Maybe the design of the humanb encoding changed and the Literal variant became useless?
|
Yeah, I think the design of |
apoelstra
approved these changes
Apr 23, 2024
uncomputable
added a commit
to BlockstreamResearch/simfony
that referenced
this pull request
Apr 23, 2024
970b841 Cargo: Make WASM compatible (Christian Lewe) aae8139 Cargo: Remove lazy_static (Christian Lewe) Pull request description: Use the latest rust-simplicity master which is compatible with WASM. The version on crates.io is not yet compatible. Depends on BlockstreamResearch/rust-simplicity#214 ACKs for top commit: apoelstra: ACK 970b841 Tree-SHA512: 95c5df1cddc51d57a12bff7a6cbe69848be768d3f101eba58e88444a2ed562dcd6d61da22e5fca6b8d0957e0863afc6cd4cc10edc8dad6f234403c2780e60281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error that was introduced in #212. Fix clippy.