Display expression #216
Merged
Display expression #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display Simplicity expression as a linear string. The linear string is potentially exponentially larger than the originally shared expression. Therefore, I add a constructor that the user has to explicitly call. Similar to bitcoin::key::KeyPair::display_secret(). Do some simple transformations to increase readability. I do these transformations on-the-fly as I am iterating over the tree. There is minimal redundancy because `iden` and `unit` nodes need to check their parents to know their serialization. This should be neglible in the face of the exponential blowup which might occur due to lack of sharing. We _could_ introduce a new node type that adds new leaves for `false`, `true`, `oih`, etc., but I don't feel like doing that work right now.
apoelstra
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display Simplicity expressions as linear strings, like in the tech report. Include some simple transformations like infix
pairandcomp, andtrueorfalse, and the{O,I,H}notation. This will make debugging much easier.