Construct Types #217
Merged
Construct Types #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computing a final type from other final types is entirely safe. There is no way to introduce variables in the process. We need Final to represent types without variables, so we need these constructors.
Use same phrasing as for Final
apoelstra
approved these changes
May 28, 2024
uncomputable
added a commit
to uncomputable/simfony
that referenced
this pull request
Jun 6, 2024
Latest master for better type support BlockstreamResearch/rust-simplicity#217 BlockstreamResearch/rust-simplicity#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the constructors for
Finalpublic and update documentation.I would like these constructors to return
Selfinstead ofArc<Self>, because then the caller can choose how he wants to save the returned value. However, we would need to change the union bound code for that, which seems too invasive for now.