Word jets with word values #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch node::Inner::Word(Value) to node::Inner::Word(Word) and adapt all code that touches word jets.
Replace recursive code with a loop over Value::iter_compact.
Optimize the `scribe` expression by using as many word jets as possible. The resulting expression should smaller, faster and cheaper in fees. We need the old, unoptimized `scribe` to generate Cmr::BITS. Expect for that, I don't see any reason why anyone would use the unoptimized `scribe`. To users shooting themselves in the foot, I redefine `CoreConstructible::scribe` as the optimized variant.
|
Nice! Pretty slick that we can just use TMR comparisons like this to detect when values are words. Later we may even want to "optimize" the TMR type into an enum where we special-case a few dozen common/special values, so we can compare just a couple bytes rather than 32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Word jets can only host word values. Currently, our code has some assertions here and there that will fail at runtime if a non-word is passed. The assertions are not fully rigorous, especially regarding the maximum word type of
TWO^(2^31).This PR introduces the wrapper type
Wordwhich is guaranteed to be a valid word.Wordis used everywhere where a word should be used.This PR also optimized scribe to use as many word jets as possible. Fixes #155