clippy fixes: make some lifetimes anonymous and add send/sync to types::BoundRef #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a block comment inline explaining the safety.
apoelstra
force-pushed
the
2025-01--send-sync
branch
from
0bee77a to
5696096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types::BoundRefis an internal type which includes a sort of weak pointer to anArccontaining a slab allocation used by the type inference engine.It is
SendandSyncby construction but the compiler does not recognize this because it includes a raw pointer. Add explicit implementations with a safety comment explaining why it is okay.Fixes #258