Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention how to deal with MuSig rounds in multi-hop locks #6

Merged
merged 1 commit into from
Jul 7, 2019

Conversation

jonasnick
Copy link
Collaborator

There shouldn't be any additional overhead due to MuSig rounds because the hops will have exchanged nonce commitments already and the left hop knows the transaction that is going to be signed. However, I don't know the BOLTs well enough to be sure that there isn't some corner case where the left hop can't create the transaction "for" the right hop.

@t-bast
Copy link
Contributor

t-bast commented Jun 27, 2019

Thanks for the clarification, it looks good to me.

However, I don't know the BOLTs well enough to be sure that there isn't some corner case where the left hop can't create the transaction "for" the right hop.

The left hop is always able to construct the right hop's transaction, that's what enables creating the same commitment transactions trustlessly on both sides to exchanges signatures and revoke previous commitments (this is true in both the current construction and eltoo). So I think you don't need to be concerned about that.

I also had a look at your previous PR (#5) I think it's a very helpful clarification. Were you able to make progress on this too?

@jonasnick
Copy link
Collaborator Author

Thanks for the review (I wasn't able to find you in IRC anymore). Good point about the commitment transactions. Re #5 iirc @apoelstra ACK'd it in private and waxwing thought it was unnecessary complication (but I don't know how close he looked at the proposal), so thanks for providing your opinion.

@t-bast
Copy link
Contributor

t-bast commented Jun 27, 2019

I must admit I only looked at #5 from the point of view of multi-hop locks, but I will spend some time on the three other use-cases to form a better opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants