Fixed LAPS attributes #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated LAPS password attributes
Updated logic to create ReadLAPSPassword edges based on updated LAPS password attributes
Updated logic to pull GUIDs for new LAPS password attributes
Corrected new LAPS password expiry attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @rvazarkar attributes for "new" LAPS were not being captured due to typos
Motivation and Context
ReadLAPSPassword edges were not being created as the password attributes were not captured in the GUID map
How Has This Been Tested?
This has not been tested, just sanity checked by matching up the names in the AD schema
Screenshots (if appropriate):
Example of the ms-LAPS-EncryptedPassword GUID
Types of changes
Checklist: