Refactor: use switch instead of if.

Bloodbat · Sep 30, 2024 · 976a822 · 976a822
1 parent cc92bd9
commit 976a822
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 18 deletions.
diff --git a/src/apices.cpp b/src/apices.cpp
@@ -335,21 +335,24 @@ struct Apices : SanguineModule {
 			parameters[i] = adcValue[i];
 		}
 
-		if (editMode == EDIT_MODE_SPLIT) {
-			processors[0].CopyParameters(&parameters[0], 2);
-			processors[1].CopyParameters(&parameters[2], 2);
-			processors[0].set_control_mode(peaks::CONTROL_MODE_HALF);
-			processors[1].set_control_mode(peaks::CONTROL_MODE_HALF);
-		}
-		else if (editMode == EDIT_MODE_TWIN) {
+		switch (editMode)
+		{
+		case EDIT_MODE_TWIN:
 			processors[0].CopyParameters(&parameters[0], 4);
 			processors[1].CopyParameters(&parameters[0], 4);
 			processors[0].set_control_mode(peaks::CONTROL_MODE_FULL);
 			processors[1].set_control_mode(peaks::CONTROL_MODE_FULL);
-		}
-		else {
+			break;
+		case EDIT_MODE_SPLIT:
+			processors[0].CopyParameters(&parameters[0], 2);
+			processors[1].CopyParameters(&parameters[2], 2);
+			processors[0].set_control_mode(peaks::CONTROL_MODE_HALF);
+			processors[1].set_control_mode(peaks::CONTROL_MODE_HALF);
+			break;
+		default:
 			processors[0].set_control_mode(peaks::CONTROL_MODE_FULL);
 			processors[1].set_control_mode(peaks::CONTROL_MODE_FULL);
+			break;
 		}
 	}
 

diff --git a/src/mortuus.cpp b/src/mortuus.cpp
@@ -424,21 +424,24 @@ struct Mortuus : SanguineModule {
 			parameters[i] = adcValue[i];
 		}
 
-		if (editMode == EDIT_MODE_SPLIT) {
-			processors[0].CopyParameters(&parameters[0], 2);
-			processors[1].CopyParameters(&parameters[2], 2);
-			processors[0].set_control_mode(deadman::CONTROL_MODE_HALF);
-			processors[1].set_control_mode(deadman::CONTROL_MODE_HALF);
-		}
-		else if (editMode == EDIT_MODE_TWIN) {
+		switch (editMode)
+		{
+		case EDIT_MODE_TWIN:
 			processors[0].CopyParameters(&parameters[0], 4);
 			processors[1].CopyParameters(&parameters[0], 4);
 			processors[0].set_control_mode(deadman::CONTROL_MODE_FULL);
 			processors[1].set_control_mode(deadman::CONTROL_MODE_FULL);
-		}
-		else {
+			break;
+		case EDIT_MODE_SPLIT:
+			processors[0].CopyParameters(&parameters[0], 2);
+			processors[1].CopyParameters(&parameters[2], 2);
+			processors[0].set_control_mode(deadman::CONTROL_MODE_HALF);
+			processors[1].set_control_mode(deadman::CONTROL_MODE_HALF);
+			break;
+		default:
 			processors[0].set_control_mode(deadman::CONTROL_MODE_FULL);
 			processors[1].set_control_mode(deadman::CONTROL_MODE_FULL);
+			break;
 		}
 	}