Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 8 Support #2

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Java 8 Support #2

merged 1 commit into from
Feb 20, 2024

Conversation

NotGeri
Copy link
Member

@NotGeri NotGeri commented Feb 19, 2024

There were a few missing pieces to support Java 8:

  1. Without using the --release 8 flag, we missed some new language features which error at runtime
  2. Some packages conflict with older Spigot/Paper versions, so we need to relocate them
  3. After fixing the first point, the unsafe reflection logic does not build correctly. ATM, I could not find a better way, such as how Velocity lets you swap out the channel, so we just skip Waterfall for this flag. All of our runtime Java versions will work with this fine.
    More info: https://github.com/Bloom-host/Issues/issues/55

This should allow 1.8.x - 1.20.x and Java 8 - Java 17 support

@NotGeri NotGeri merged commit fdc1a4a into main Feb 20, 2024
1 check passed
@NotGeri NotGeri deleted the feature/java-8 branch February 20, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant