Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove __future__ imports #473

Merged
merged 2 commits into from
Oct 12, 2023
Merged

remove __future__ imports #473

merged 2 commits into from
Oct 12, 2023

Conversation

AurelienJaquier
Copy link
Collaborator

I only removed one line in each jupyter notebook, and it does not look like anything else has changed, when checking visually. @anilbey do you know why other lines have been unilateraly changed here?

@AurelienJaquier AurelienJaquier self-assigned this Oct 5, 2023
@anilbey
Copy link
Contributor

anilbey commented Oct 5, 2023

Nice change.

Yeah jupyter and git do these. Those differences must be created after you execute the cells.

@anilbey
Copy link
Contributor

anilbey commented Oct 5, 2023

So I think if you git reset and then remove the lines and not execute the notebook cells then it should not add those.

@AurelienJaquier
Copy link
Collaborator Author

I actually did not execute the cells. I just removed the line, and saved in VScode.

@anilbey
Copy link
Contributor

anilbey commented Oct 5, 2023

Oh, I see. Hmm if vscode did something and not displayed it, then the javascript lines can still be selected via git add -p PATH_TO_NOTEBOOK if you want to remove them.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f7fd66d) 87.31% compared to head (8c8fb4b) 87.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files          50       50           
  Lines        4336     4329    -7     
=======================================
- Hits         3786     3780    -6     
+ Misses        550      549    -1     
Files Coverage Δ
bluepyopt/deapext/tools/selIBEA.py 100.00% <100.00%> (ø)
bluepyopt/ephys/serializer.py 100.00% <ø> (ø)
bluepyopt/ipyp/bpopt_tasksdb.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier merged commit a263ade into master Oct 12, 2023
5 checks passed
@AurelienJaquier AurelienJaquier deleted the removefuture branch October 12, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants