Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums should have a defined type #247

Open
mgeplf opened this issue Mar 9, 2021 · 2 comments
Open

Enums should have a defined type #247

mgeplf opened this issue Mar 9, 2021 · 2 comments

Comments

@mgeplf
Copy link
Contributor

mgeplf commented Mar 9, 2021

#243 Fixes a type conversion, but since C++11, we can specify the type, to make this more clear.

@wizmer
Copy link
Contributor

wizmer commented Mar 9, 2021

Pinging @jacquemi-bbp because this can be part of #242.
This PR will transform the SectionType enum into a class enum so we can take this opportunity to also give them a type.

The reason is that glia will have a new enum to store their own section type (instead of using a SectionType enum which currently holds values for both the neurons and the glia as done now).
In this context, if glia and neuron want to use the same label (for example, if both need a type call "undefined") this is not possible without using class enums.

@jacquemi-bbp
Copy link

+1
spine will also have a new enum to store their own section type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants