Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make intel compiler happy #246

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Make intel compiler happy #246

merged 1 commit into from
Mar 9, 2021

Conversation

wizmer
Copy link
Contributor

@wizmer wizmer commented Mar 9, 2021

By fixing a narrow conversion
Fixes: #243

By fixing a narrow conversion
@wizmer wizmer marked this pull request as ready for review March 9, 2021 13:54
@wizmer wizmer requested a review from mgeplf March 9, 2021 13:54
@mgeplf
Copy link
Contributor

mgeplf commented Mar 9, 2021

I guess this works for now, but the enum's type should probably be made explicit at some point in the future. I'll make a ticket, but we don't need to change it now.

@wizmer wizmer merged commit 78de825 into BlueBrain:master Mar 9, 2021
@wizmer wizmer deleted the fix branch March 9, 2021 14:25
@GianlucaFicarelli
Copy link

I guess this works for now, but the enum's type should probably be made explicit at some point in the future. I'll make a ticket, but we don't need to change it now.

As an alternative to casting, it seems that the error could be fixed adding unsigned int to the enum definition here, as in:

enum CellFamily : unsigned int { NEURON = 0, GLIA = 1 };

Is this what you suggest?

@mgeplf
Copy link
Contributor

mgeplf commented Mar 9, 2021

Is this what you suggest?

Yeah, that's what I mentioned in #247 (comment)

It's a breaking ABI change though, so if we're going to do it properly, we need to do it all at once, and version the ABI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants