No scanf tokenstream #460
Open
No scanf tokenstream #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add check for negative IDs
mgeplf
force-pushed
the
no-scanf-tokenstream
branch
from
ed331a4
to
20e8888
Compare
mgeplf
force-pushed
the
no-scanf-tokenstream
branch
from
20e8888
to
e7a674a
Compare
Closed
|
It passes all the tests, including the ones from NeuroM. Please let me know if it's understandable. |
|
As of 081aeca this improves performance (parsing an SWC goes from 1.01ms to 0.817ms) and supports locales. |
mgeplf
force-pushed
the
no-scanf-tokenstream
branch
from
081aeca
to
00b8bbb
Compare
mgeplf
force-pushed
the
no-scanf-tokenstream
branch
from
879c914
to
cf83223
Compare
| @@ -153,12 +152,21 @@ class ErrorMessages | |||
| /** Section self parent error message */ | |||
| std::string ERROR_SELF_PARENT(const Sample& sample) const; | |||
|
|
|||
| /** The end of the file was reached before parsing finshed */ | |||
There was a problem hiding this comment.
Suggested change
| /** The end of the file was reached before parsing finshed */ | |
| /** The end of the file was reached before parsing finished */ |
Comment on lines
+4
to
+6
| #if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
| #define freelocale _free_locale | ||
| #define strtol_l _strtol_l |
There was a problem hiding this comment.
Maybe add a comment here concerning the freelocale?
Comment on lines
+25
to
+31
| #if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
| : locale(_create_locale(LC_ALL, "C")) { | ||
| } | ||
| #else | ||
| : locale(newlocale(LC_NUMERIC_MASK, "POSIX", nullptr)) { | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Same here. It's not clear to me why these are configured this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.