-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No scanf tokenstream #460
base: master
Are you sure you want to change the base?
No scanf tokenstream #460
Conversation
* add check for negative IDs
ed331a4
to
20e8888
Compare
20e8888
to
e7a674a
Compare
It passes all the tests, including the ones from NeuroM. Please let me know if it's understandable. |
As of 081aeca this improves performance (parsing an SWC goes from 1.01ms to 0.817ms) and supports locales. |
081aeca
to
00b8bbb
Compare
879c914
to
cf83223
Compare
@@ -153,12 +152,21 @@ class ErrorMessages | |||
/** Section self parent error message */ | |||
std::string ERROR_SELF_PARENT(const Sample& sample) const; | |||
|
|||
/** The end of the file was reached before parsing finshed */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** The end of the file was reached before parsing finshed */ | |
/** The end of the file was reached before parsing finished */ |
#if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
#define freelocale _free_locale | ||
#define strtol_l _strtol_l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment here concerning the freelocale?
#if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
: locale(_create_locale(LC_ALL, "C")) { | ||
} | ||
#else | ||
: locale(newlocale(LC_NUMERIC_MASK, "POSIX", nullptr)) { | ||
} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. It's not clear to me why these are configured this way.
No description provided.