Efficient swc build #476
Open
Efficient swc build #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add check for negative IDs
…NEUROMORPHO_THREE_POINT_CYLINDERS
* Allow SWC files to have single point sections (since parent is soma)
ex:
1 1 0 0 0 10 -1
2 3 1 0 0 1 1
Gets parsed by NEURON as:
|-| model:
.soma[0](0-1)
.dend[0](0-1)
Where the dend has the points:
0: x: 0.0 y: 0.0, z: 0.0
1: x: 1.0 y: 0.0, z: 0.0
mgeplf
force-pushed
the
efficient-swc-build
branch
from
c8a670e
to
0f15036
Compare
| uint32_t id = 0; | ||
| // create duplicate point if needed | ||
| if (!is_root && sample->point != start_point /*|| sample->diameter != start_diameter */) { | ||
| //if (!(is_root && sample->type == SECTION_SOMA) && sample->point != start_point /*|| sample->diameter != start_diameter */) { |
There was a problem hiding this comment.
Is this intentionally commented out?
eleftherioszisis
approved these changes
May 27, 2024
Comment on lines
+4
to
+6
| #if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
| #define freelocale _free_locale | ||
| #define strtol_l _strtol_l |
There was a problem hiding this comment.
Maybe add a comment here concerning the freelocale?
Comment on lines
+24
to
+31
| StringToNumber::StringToNumber() | ||
| #if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
| : locale(_create_locale(LC_ALL, "C")) { | ||
| } | ||
| #else | ||
| : locale(newlocale(LC_NUMERIC_MASK, "POSIX", nullptr)) { | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Same here. It's not clear to me why these are configured this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SWC parser: