-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficient swc build #476
base: master
Are you sure you want to change the base?
Efficient swc build #476
Conversation
* add check for negative IDs
…NEUROMORPHO_THREE_POINT_CYLINDERS
* Allow SWC files to have single point sections (since parent is soma) ex: 1 1 0 0 0 10 -1 2 3 1 0 0 1 1 Gets parsed by NEURON as: |-| model: .soma[0](0-1) .dend[0](0-1) Where the dend has the points: 0: x: 0.0 y: 0.0, z: 0.0 1: x: 1.0 y: 0.0, z: 0.0
c8a670e
to
0f15036
Compare
uint32_t id = 0; | ||
// create duplicate point if needed | ||
if (!is_root && sample->point != start_point /*|| sample->diameter != start_diameter */) { | ||
//if (!(is_root && sample->type == SECTION_SOMA) && sample->point != start_point /*|| sample->diameter != start_diameter */) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentionally commented out?
#if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
#define freelocale _free_locale | ||
#define strtol_l _strtol_l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment here concerning the freelocale?
StringToNumber::StringToNumber() | ||
#if defined(_WIN32) || defined(__WIN32__) || defined(WIN32) | ||
: locale(_create_locale(LC_ALL, "C")) { | ||
} | ||
#else | ||
: locale(newlocale(LC_NUMERIC_MASK, "POSIX", nullptr)) { | ||
} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. It's not clear to me why these are configured this way.
New SWC parser: