This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
Changes to support async execution on GPU with OpenACC #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
reviewed
Dec 21, 2021
| @@ -1950,7 +1950,7 @@ void bablk(ba, type, q1, q2) | |||
| " _thread = _ml->_thread;\n" | |||
| " double * _nt_data = _nt->_data;\n" | |||
| " double * _vec_v = _nt->_actual_v;\n" | |||
| " int stream_id = _nt->stream_id;\n" | |||
| " int stream_id = _nt->streams[_nt->stream_id];\n" | |||
| " #if LAYOUT == 1 /*AoS*/\n" | |||
There was a problem hiding this comment.
@iomaganaris : remind me better - MOD2C remains only OpenACC (and not OpenMP). So does this change required in MOD2C i.e. using _nt->stream_id as async launch stream for OpenACC works fine right? 🤔
There was a problem hiding this comment.
It does, yes. I just changed this to be similar to the form needed by OpenMP for homogenity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows changes from BlueBrain/CoreNeuron#725