Skip to content

Commit

Permalink
Remove dependency on mvdtool (#112)
Browse files Browse the repository at this point in the history
## Context
The last commit has blocked the simulations with BlueConfig files, so we
are now only support SONATA data format. `mvdtool` is used for reading
old mvd3 node files which is no longer needed and can be removed.

## Scope
This PR removes the dependency on `mvdtool` from the package
configuration file (`pyproject.toml`). The relevant source functions
will be cleaned up in the next PRs for further deprecating
legacy/BlueConfig.

A small fix on the unit test regarding the default value of "output_dir" from libsonata 0.1.25

## Testing
Existing tests

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [x] Unit/Scientific test added
* [x] Updated Readme, in-code, developer documentation
  • Loading branch information
WeinaJi authored Jan 22, 2024
1 parent 493e8ea commit af5c907
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion docs/development.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ There are also optional dependencies required for some functionalities, so keep
- scipy
- morphio
- NEURON
- mvdtool

Nowadays all these dependencies can be found in PyPI, so it's not a big problem to meet them. Indeed, after a plain "pip install," you can already call the "neurodamus" entry point and inspect the usage.
However, as mentioned, without a compiled model for Neuron, there's nothing much it can do. More on that later.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies = [

[project.optional-dependencies]
plotting=['matplotlib'] # only for Neurodamus HL API
full=['scipy', 'morphio', 'NEURON', 'mvdtool']
full=['scipy', 'morphio', 'NEURON']

[project.scripts]
neurodamus = "neurodamus.commands:neurodamus"
Expand Down
2 changes: 1 addition & 1 deletion tests/scientific/test_projections.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def test_synapse_delay_override(sonata_config_file):
# If the target simulator is CoreNEURON, read the soma voltage report
if target_simulator == "CORENEURON":
# Load soma voltage data from the report file
soma_report_path = Path(config_file.name).parent / "soma.h5"
soma_report_path = os.path.join(nd._run_conf["OutputRoot"], "soma.h5")
voltage_vec = _read_sonata_soma_report(soma_report_path)

# Find impact on voltage. See test_spont_minis for an explanation
Expand Down

0 comments on commit af5c907

Please sign in to comment.