Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move print_function_call. #1115

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 8, 2023

Additionally, adds stubs for print_net_{send,move,event}_call to CodegenNeuronCppVisitor.

Additionally, adds stubs for `print_net_{send,move,event}_call` to
`CodegenNeuronCppVisitor`.
@1uc 1uc force-pushed the 1uc/move-print_function_call branch from f34026f to a30f4dd Compare December 8, 2023 08:47
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b6801af) 88.24% compared to head (a30f4dd) 88.21%.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
- Coverage   88.24%   88.21%   -0.03%     
==========================================
  Files         175      175              
  Lines       12960    12964       +4     
==========================================
  Hits        11436    11436              
- Misses       1524     1528       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review December 8, 2023 09:50
@iomaganaris iomaganaris merged commit 7dbdd23 into master Dec 8, 2023
17 checks passed
@iomaganaris iomaganaris deleted the 1uc/move-print_function_call branch December 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants