Use compiled version of spdlog. #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 30, 2024
When using an external copy of spdlog it'll pick up the shared library. When built from the submodule it creates a static library.
JCGoran
approved these changes
Oct 1, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see that in NMODL using the header-only version of SPDLOG contributes noticeably to the compile time:
However, this can be easily avoided by using a non-headeronly version of SPDLOG.
When using an external copy of spdlog it'll pick up the shared library. When built
from the submodule it creates a static library.