Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LONGITUDINAL_DIFFUSION. #1504

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Implement LONGITUDINAL_DIFFUSION. #1504

merged 4 commits into from
Oct 10, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Oct 8, 2024

No description provided.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 8, 2024
@1uc 1uc force-pushed the 1uc/longitudinal_diffusion branch from b643cec to 3538999 Compare October 8, 2024 09:16
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 8, 2024
@1uc 1uc marked this pull request as ready for review October 8, 2024 09:45
@1uc 1uc force-pushed the 1uc/longitudinal_diffusion branch from 3538999 to 82048e1 Compare October 8, 2024 12:33
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 8, 2024
src/language/codegen.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly minor comments.

src/visitors/longitudinal_diffusion_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_info.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.hpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.hpp Outdated Show resolved Hide resolved
src/codegen/codegen_helper_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_info.hpp Show resolved Hide resolved
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 10, 2024
@1uc 1uc merged commit 22e45f1 into master Oct 10, 2024
12 checks passed
@1uc 1uc deleted the 1uc/longitudinal_diffusion branch October 10, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants