Fix incorrect key polling in key calibration routine (misplaced semicolon) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've accidentally added other commits from my fork. Removing them now 😄 |
The key polling cycle in the key calibration routine has a misplaced semicolon, which prevented WaitVBL() to run on each poll (cycle).
64kramsystem
force-pushed
the
fix_incorrect_key_wait
branch
from
c36192d to
c72b65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key polling cycle in the key calibration routine has a misplaced semicolon, which prevented WaitVBL() to run on each poll (cycle).
I'm actually no expert 😬 - I've just compared the source project with the port, and had a look at the APIs involved. The calibration actually works fine either way.