Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy projection generation + fixed "do all possible joins by default" problem #88

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yargray
Copy link
Contributor

@yargray yargray commented Jul 31, 2015

Hi!

I hope that these changes are quite useful. Now I can generate projections by *Selection objects like other criterias:

new ArticleSelection().forId().forTitle().forText().orderByDate().query(resolver);
// instead of
new ArticleSelection().orderByDate().query(resolver, new String[] {
    ArticleColumns._ID, ArticleColumns.TITLE, ArticleColumns.TEXT
})
// Now default selection criteria:
new ArticleSelection().query(resolver);
// means
new ArticleSelection().query(resolver, ArticleColumns.ALL_COLUMNS);
// instead of
new ArticleSelection().query(resolver, null);
// which means large and dangerous set of joins like "article JOIN catalog JOIN domain JOIN ... etc"

Client should visibly declare the specific joining columns to do the specific join:

new ArticleSelection().forId().forTitle().forCatalogName().forDomainName().query(resolver);
// "article JOIN catalog JOIN domain

Thanks for your attention

@frigus02
Copy link

Looks like this would solve the mentioned issue (#86). Any chance that this will get merged?

@BoD
Copy link
Owner

BoD commented Oct 31, 2015

I am very sorry I haven't had the time to look at this yet. I can't promise anything, but I hope I will have some free time "soon" to look at it :) Again, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants