Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

476 split environmental impact by k8s #477

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damienfernandes
Copy link
Contributor

Closes #476

@demeringo
Copy link
Collaborator

Hi, thanks for the PR.

I did not look much in the code yet but a few quick remarks:

  • we should provide a design doc (explaining the principle of scraping pods data already exposed in prometheus by a separate node exporter).
  • we should also update user manual with and example of usage of the new paremeters.
  • Maybe decorelate inventory of K8S resources from other cloud resources <(maybe a separate model).
  • See if we can get rid of dependency against OpenSSL (For some libs I use rusttls as an alternative tls provider to ease cross compiliation: https://docs.rs/prometheus-http-query/latest/prometheus_http_query/#features
  • fix the failing test
  • make clippy happy by prefinging non used var by an underscore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split environmental impact by K8s pod usage
2 participants