reviewing against franton code #56
Annotations
3 errors and 10 warnings
Build and test:
apps/core/test/core_test.exs#L5
test greets the world (CoreTest)
|
Build and test:
apps/naive/test/naive_test.exs#L11
test Naive trader full trade(buy + sell) test (NaiveTest)
|
Build and test
Process completed with exit code 2.
|
Build and test
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, erlef/setup-beam@61e01a43a562a89bfc54c7f9a378ff67b03e4a21, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build and test
Application.get_env/2 is discouraged in the module body, use Application.compile_env/3 instead
|
Build and test
use Bitwise is deprecated. import Bitwise instead
|
Build and test
use Bitwise is deprecated. import Bitwise instead
|
Build and test
^^^ is deprecated. It is typically used as xor but it has the wrong precedence, use Bitwise.bxor/2 instead
|
Build and test
^^^ is deprecated. It is typically used as xor but it has the wrong precedence, use Bitwise.bxor/2 instead
|
Build and test
System.stacktrace/0 is deprecated. Use __STACKTRACE__ instead
|
Build and test
:sys.get_debug/3 is deprecated. Incorrectly documented and only for internal use. can often be replaced with sys:get_log/1
|
Build and test
Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead
|
Build and test
Core.hello/0 is undefined or private
|