-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Atkin sieve #172
base: master
Are you sure you want to change the base?
WIP Atkin sieve #172
Conversation
9c36761
to
d58c5f2
Compare
This is more or less ready per se. But unfortunately prime counting is so intimately (and impenetrably) connected to the existing Eratosthenes sieve, that I cannot decomission the latter. That said, this PR is on hold until I disentangle this knot. |
Hey @Bodigrim,
I understand that merging this as is without removing the earlier sieve code would just clutter the codebase (even further), but if it's already working with good performance, wouldn't merging it now and making a new PR that proceeds with decoupling the |
My main goal here is to make source code more maintainable. I can even agree to worsen performance mildly. It might happen that I'd never untangle |
@Bodigrim can't say I don't understand. It's already difficult enough maintaining the package as it is - I remember trying to migrate from |
95c2345
to
09a9d5f
Compare
Closes #157
It is already competitive with the existing sieve and is 10 times simpler, but I need to merge more performance patches into https://github.com/Bodigrim/bitvec to make this code really shine.