feat: Add functional test suite #335
Draft
+132
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new functional test suite to the project to alleviate the burden and error-prone process for maintainers to have to build and functionally test each PR change that contains core validator changes. The functional tests compile the CLI binary once and then execute it as a subprocess for each test case. Assertions are made against the CLI's exit code and stdout/stderr to verify the correct behavior. The following tests have been added: - `TestHelp`: Tests the `--help` flag. - `TestVersion`: Tests the `--version` flag. - `TestBadPath`: Tests the handling of a non-existent path. - `TestInvalidFlag`: Tests the handling of an invalid flag. - `TestBasicValidation`: Tests a basic validation run. - `TestQuietFlag`: Tests the `--quiet` flag.
kehoecj
added
OSS Community Contribution
kehoecj
requested changes
Oct 10, 2025
There was a problem hiding this comment.
Some changes:
- Would like the tests to be broken out into files by features being tested instead of a single functional_test.go file to support future test growth
- Look into using something like testscript rather than building the CLI in the tests
kehoecj
added
pr-action-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a functional test suite for the tool - Closes #123