테스트 시 나왔던 버그 및 개선 사항 수정 (#78)

* flx : 자유게시판 css 수정 * fix : 구매 페이지 오류 발생해도 스니펫 떠있는 버그 수정 * fix : oAuth 리다이렉트 url 수정
Book-Pie · Feb 15, 2022 · ad991d1 · ad991d1
1 parent 1ba701f
commit ad991d1
Show file tree

Hide file tree

Showing 7 changed files with 44 additions and 41 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -1,11 +1,11 @@
 name: React build
 on: 
   push:                              
-    branches: [ action ] # action Branch에서 push 이벤트가 일어났을 때만 실행
+    branches: [ release ] # action Branch에서 push 이벤트가 일어났을 때만 실행
 
 jobs:
   build:
-    runs-on: [ubuntu-latest]
+    runs-on: ubuntu-18.04
     steps:
       - name: Checkout source code.   # 레포지토리 체크아웃
         uses: actions/checkout@v2

diff --git a/src/components/FreeBoard/FreeBoard.tsx b/src/components/FreeBoard/FreeBoard.tsx
@@ -187,13 +187,17 @@ const FreeBoard = () => {
                 </div>
               </div>
               <div>
-                <Button variant="contained" color="mainDarkBrown">
-                  <Link to="/community/freeboard">목록보기</Link>
-                </Button>
-                {user && (
-                  <Button variant="contained" color="info">
-                    <Link to="insert">게시글 등록</Link>
+                <Link to="/community/freeboard">
+                  <Button variant="contained" color="mainDarkBrown">
+                    목록보기
                   </Button>
+                </Link>
+                {user && (
+                  <Link to="insert">
+                    <Button variant="contained" color="info">
+                      게시글 등록
+                    </Button>
+                  </Link>
                 )}
                 {user?.id === userId && (
                   <>

diff --git a/src/components/FreeBoardList/FreeBoardList.tsx b/src/components/FreeBoardList/FreeBoardList.tsx
@@ -148,7 +148,6 @@ const FreeBoardList = () => {
                     </div>
                     <div>
                       <span>{dateArrayFormat(boardDate)[0]}</span>
-                      <span>{dateArrayFormat(boardDate)[1]}</span>
                     </div>
                   </div>
                 );
@@ -175,27 +174,21 @@ const FreeBoardList = () => {
             </Stack>
           )}
           <Styled.FreeBoardListSearch onSubmit={handleSubmit(onSubmit)}>
-            <div>
-              <Controller
-                name="title"
-                control={control}
-                rules={titleOptions}
-                render={({ field }) => (
-                  <TextField
-                    {...field}
-                    type="text"
-                    size={min900 ? "medium" : "small"}
-                    color="mainDarkBrown"
-                    placeholder="자유게시판 제목을 입력해주세요."
-                  />
-                )}
-              />
-              <Button variant="contained" size={min900 ? "large" : "small"} color="mainDarkBrown" type="submit">
-                검색
-              </Button>
-            </div>
-            <ErrorMessage message={errors.title?.message} />
+            <Controller
+              name="title"
+              control={control}
+              rules={titleOptions}
+              render={({ field }) => (
+                <TextField {...field} type="text" color="mainDarkBrown" placeholder="자유게시판 제목을 입력해주세요." />
+              )}
+            />
+            <Button variant="contained" size={min900 ? "large" : "small"} color="mainDarkBrown" type="submit">
+              검색
+            </Button>
           </Styled.FreeBoardListSearch>
+          <div>
+            <ErrorMessage message={errors.title?.message} />
+          </div>
         </Styled.FreeBoardListWrapper>
       </>
     );

diff --git a/src/components/FreeBoardList/style.ts b/src/components/FreeBoardList/style.ts
@@ -2,10 +2,14 @@ import styled from "styled-components";
 
 export const FreeBoardListWrapper = styled.div`
   margin: 20px 0;
+
+  .MuiInputBase-root {
+    height: 100%;
+  }
 `;
 
 export const FreeBoardListRow = styled.div`
-  min-height: 400px;
+  min-height: 300px;
   & > div {
     display: flex;
     align-items: center;
@@ -32,7 +36,7 @@ export const FreeBoardListRow = styled.div`
       flex-wrap: wrap;
       gap: 10px;
       justify-content: center;
-      font-size: 15px;
+      font-size: 13px;
       overflow: hidden;
       text-overflow: ellipsis;
       white-space: nowrap;
@@ -130,12 +134,11 @@ export const Empty = styled.div`
 `;
 
 export const FreeBoardListSearch = styled.form`
-  & > div {
-    margin-top: 20px;
-    justify-content: center;
-    display: flex;
-    gap: 20px;
-  }
+  height: 45px;
+  margin-top: 20px;
+  justify-content: center;
+  display: flex;
+  gap: 20px;
   input {
     width: 250px;
   }

diff --git a/src/components/Header/Header.tsx b/src/components/Header/Header.tsx
@@ -136,8 +136,11 @@ const Header = () => {
             <Link to="/book">리뷰</Link>
           </span>
           <span>
-            <Link to="/community">커뮤니티</Link>
+            <span>커뮤니티</span>
             <ul>
+              <li>
+                <Link to="/community">공지사항</Link>
+              </li>
               <li>
                 <Link to="/community/freeboard">자유게시판</Link>
               </li>

diff --git a/src/components/OrderForm/OrderForm.tsx b/src/components/OrderForm/OrderForm.tsx
@@ -93,7 +93,7 @@ const OrderForm = ({ usedBook }: Types.OrderFormProps) => {
       const message = errorHandler(e);
       handlePopupMessage(false, message);
     } finally {
-      setIsLoading(true);
+      setIsLoading(false);
     }
   };
 

diff --git a/webpack.config.js b/webpack.config.js
@@ -20,13 +20,13 @@ const KAKAO_CLIENT_ID = process.env.KAKAO_CLIENT_ID ?? "";
 const KAKAO_CLIENT_KEY = process.env.KAKAO_JDK_KEY ?? "";
 const PAYMENT_IMP_KEY = process.env.PAYMENT_IMP_KEY ?? "";
 const KAKAO_REDIRECT_PATH_DEV = "http://localhost:3000/oAuth/kakao";
-const KAKAO_REDIRECT_PATH_PRO = "http://www.react-dev.p-e.kr/oAuth/kakao";
+const KAKAO_REDIRECT_PATH_PRO = "http://dzjv6uzpvhcwz.cloudfront.net/oAuth/kakao";
 const KAKAO_OAUTH_URL_DEV = `https://kauth.kakao.com/oauth/authorize?client_id=${KAKAO_CLIENT_ID}&redirect_uri=${KAKAO_REDIRECT_PATH_DEV}&response_type=code`;
 const KAKAO_OAUTH_URL_PRO = `https://kauth.kakao.com/oauth/authorize?client_id=${KAKAO_CLIENT_ID}&redirect_uri=${KAKAO_REDIRECT_PATH_PRO}&response_type=code`;
 const NAVER_OAUTH_URL_DEV =
   "https://nid.naver.com/oauth2.0/authorize?response_type=code&client_id=qtbZhYGrYVHhLWesnRyJ&redirect_uri=http://localhost:3000/oAuth/naver&state=state";
 const NAVER_OAUTH_URL_PRO =
-  "https://nid.naver.com/oauth2.0/authorize?response_type=code&client_id=qtbZhYGrYVHhLWesnRyJ&redirect_uri=http://www.react-dev.p-e.kr/oAuth/naver&state=state";
+  "https://nid.naver.com/oauth2.0/authorize?response_type=code&client_id=qtbZhYGrYVHhLWesnRyJ&redirect_uri=http://dzjv6uzpvhcwz.cloudfront.net/oAuth/naver&state=state";
 const BASE_URL_DEV = "http://localhost:3000/api";
 const BASE_URL_PRO = "http://3.34.100.122:8080/api";
 const CHAT_BASE_URL = "http://ec2-3-34-249-63.ap-northeast-2.compute.amazonaws.com:8081";