-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
라우터 구조 변경 (중첩 라우틱 적용, 레이아웃 믹스인 포함) #273
Merged
Merged
+70
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyerindev
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 😊
rwaeng
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 루트 레이아웃 파일 분리 확인했습니다~!!
hyerindev
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 What is this PR?
✨ 설명
레이아웃 믹스인 반영하여 아울렛 적용하였습니다.
레이아웃과 아울렛이 밀접한 연관이 있는 것 같아 이슈넘버 레이아웃 믹스인 #249 를 그대로 사용했습니다. 머지 브랜치 역시 249-layout입니다.
커밋 메세지 바디에 자세히 작성하려 했는데, 이를 잊어 설명에 작성합니다.
Layout jsx 컴포넌트 생성 696b0fb
루트 레이아웃 생성 f02b00f
라우터 구조 변경 f9b1860
📷 스크린샷 (선택)
☑️ 테스트 체크리스트
💡 집중 리뷰 요청