Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useModal ํ›… #282

Merged
merged 5 commits into from
Jan 27, 2025
Merged

useModal ํ›… #282

merged 5 commits into from
Jan 27, 2025

Conversation

hyerindev
Copy link
Member

@hyerindev hyerindev commented Jan 26, 2025

๐Ÿ”Ž What is this PR?

โœจ ์„ค๋ช…

useModal ํ›… ํ•˜๋‚˜๋กœ ๋‹ค์ด์–ผ๋กœ๊ทธ, ๋ฐ”ํ…€์‹œํŠธ, ์„œ๋ฒ„๋ฐ”, ์‚ฌ์ด๋“œ๋ฐ”๋ฅผ ๋ชจ๋‘ ์ œ์–ดํ•  ์ˆ˜ ์žˆ๋„๋ก ๋ฆฌํŒฉํ† ๋งํ–ˆ์Šต๋‹ˆ๋‹ค.
useModal ํ›…์˜ ์ธ์ˆ˜ type์œผ๋กœ 'dialog', 'bottomsheet', 'serverbar', 'sidebar' ์ค‘ ํ•˜๋‚˜๋ฅผ ์„ ํƒํ•˜๋ฉด, ํ•ด๋‹น ๋ชจ๋‹ฌ์— ๋งž๋Š” RecoilState๋ฅผ ์กฐ๊ฑด๋ถ€ importํ•˜์—ฌ ์ œ์–ดํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ)

โ˜‘๏ธ ํ…Œ์ŠคํŠธ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

๐Ÿ’ก ์ง‘์ค‘ ๋ฆฌ๋ทฐ ์š”์ฒญ

๊ฐ ์ฝ”๋“œ ๋‹ด๋‹น์ž๊ป˜์„œ๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์„ ๋ฐ˜์˜ํ•ด ์ฃผ์‹œ๊ธฐ ๋ฐ”๋ž๋‹ˆ๋‹ค.

useModal ํ›… ํ•˜๋‚˜๋กœ ๋‹ค์ด์–ผ๋กœ๊ทธ, ๋ฐ”ํ…€์‹œํŠธ, ์„œ๋ฒ„๋ฐ”, ์‚ฌ์ด๋“œ๋ฐ”๋ฅผ ๋ชจ๋‘ ์ œ์–ดํ•  ์ˆ˜ ์žˆ๋„๋ก ๋ฆฌํŒฉํ† ๋งํ•จ.
@hyerindev hyerindev added refactorโ™ป๏ธ ์ฝ”๋“œ๋ฅผ ๊ฐœ์„  ๋˜๋Š” ๋‹จ์ˆœ ์ •๋ฆฌํ•จ. development๐Ÿ”จ ๊ธฐ๋Šฅ ๊ด€๋ จ labels Jan 26, 2025
@hyerindev hyerindev requested review from rwaeng and yyeonzu January 26, 2025 15:14
@hyerindev hyerindev self-assigned this Jan 26, 2025
@hyerindev hyerindev linked an issue Jan 26, 2025 that may be closed by this pull request
Copy link
Contributor

@yyeonzu yyeonzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค~ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค
๐Ÿ’ฌ serverbar๋ž‘ sidebar๋ฅผ drawer๋ผ๋Š” ์ด๋ฆ„์œผ๋กœ ๋ฐ”๊พธ์ž๊ณ  ํ•˜์…จ๋˜ ๊ฒƒ ๊ฐ™์€๋ฐ state๋Š” ์—ฌ๊ธฐ์„œ ๋ฏธ๋ฆฌ ๋ฐ”๊พธ๋Š” ๊ฑด ์–ด๋– ์„ธ์š”? ์ƒ๊ฐํ•ด๋ณด๋‹ˆ serverbar, sidebar๋Š” ๋™์‹œ์— ์˜คํ”ˆ๋  ์ผ์€ ์—†์œผ๋‹ˆ ๊ฐ™์ด ์‚ฌ์šฉํ•ด๋„ ๋  ๊ฒƒ ๊ฐ™๊ตฌ์š”

@hyerindev
Copy link
Member Author

๐Ÿ’ฌ serverbar๋ž‘ sidebar๋ฅผ drawer๋ผ๋Š” ์ด๋ฆ„์œผ๋กœ ๋ฐ”๊พธ์ž๊ณ  ํ•˜์…จ๋˜ ๊ฒƒ ๊ฐ™์€๋ฐ state๋Š” ์—ฌ๊ธฐ์„œ ๋ฏธ๋ฆฌ ๋ฐ”๊พธ๋Š” ๊ฑด ์–ด๋– ์„ธ์š”? ์ƒ๊ฐํ•ด๋ณด๋‹ˆ serverbar, sidebar๋Š” ๋™์‹œ์— ์˜คํ”ˆ๋  ์ผ์€ ์—†์œผ๋‹ˆ ๊ฐ™์ด ์‚ฌ์šฉํ•ด๋„ ๋  ๊ฒƒ ๊ฐ™๊ตฌ์š”
@yyeonzu

์˜๊ฒฌ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. PR #259 ๊ฐ€ ์ถฉ๋Œ์ด ๋งŽ๋‹ค๊ณ  ํ•ด์„œ ๋ชจ๋“  ๋ฆฌํŒฉํ† ๋ง ๊ฐœ๋ฐœ์ด ๋๋‚˜๊ณ  ๊ฐ€์žฅ ๋งˆ์ง€๋ง‰์œผ๋กœ ๋จธ์ง€ํ•˜๋ ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค. ๊ทธ๋ฆฌ๊ณ  ์ปดํฌ๋„ŒํŠธ ์ด๋ฆ„ ์ˆ˜์ • ์ž‘์—…์€ 219-directory ๋ธŒ๋žœ์น˜๊ฐ€ ๋‹ด๋‹นํ•˜๋Š” ๊ฒƒ์œผ๋กœ ์ƒ๊ฐํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ํ•˜๋‚˜์˜ ์ž‘์—…์€ ํ•˜๋‚˜์˜ ๋ธŒ๋žœ์น˜์—์„œ ์ผ๊ด„์ ์œผ๋กœ ์ž‘์—…ํ•˜๋ ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค.

Copy link
Contributor

@rwaeng rwaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค~! ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค

@hyerindev hyerindev merged commit fff2ad1 into dev Jan 27, 2025
@hyerindev hyerindev deleted the 263-usemodal branch January 27, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development๐Ÿ”จ ๊ธฐ๋Šฅ ๊ด€๋ จ refactorโ™ป๏ธ ์ฝ”๋“œ๋ฅผ ๊ฐœ์„  ๋˜๋Š” ๋‹จ์ˆœ ์ •๋ฆฌํ•จ.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useModal ํ›…
3 participants