Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add difference function and update unit_vector in arithmetic.hpp #128

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rjnrohit
Copy link

@rjnrohit rjnrohit commented Apr 14, 2020

Description

  1. The difference function added to arithmetic.hpp to calculate difference between two representation points(i.e r1 -r2 , where r1 ,r2 are coordinate representations).
  2. Unit_vector function overloaded to calculate unit_vector directing from representations(r2) to representation1(r1)(i.e r1-r2/|r1 - r2|).
  3. Tests cases have been added to verify the above implementations.

@rjnrohit
Copy link
Author

rjnrohit commented Apr 17, 2020

@lpranam @sarthak2007 please review this PR and suggest necessary changes if you want any.

Copy link
Member

@sarthak2007 sarthak2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but need to resolve the conflicts first :)

@rjnrohit
Copy link
Author

Just give me one or two days, I've to understand the changes that have been done till now. But surely I'll be able to resolve this conflict in two days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants