Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URL select for URL prop #1542

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Improve URL select for URL prop #1542

merged 2 commits into from
Apr 13, 2022

Conversation

Komediruzecki
Copy link
Contributor

@Komediruzecki Komediruzecki commented Mar 20, 2022

Add open selector when URL is empty or invalid

Showcase:

URL_Improvement_Edit2022-03-20.22-33-37.mp4

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change a bit more. For the url, users need to click the url text to navigate.

Screen Shot 2022-03-28 at 4 56 02 PM

Users should click the red area to navigate to the url.
If users click other than this area, including padding and the pencil icon, edit mode should be activated.

@Komediruzecki
Copy link
Contributor Author

Let's change a bit more. For the url, users need to click the url text to navigate.

Screen Shot 2022-03-28 at 4 56 02 PM

Users should click the red area to navigate to the url. If users click other than this area, including padding and the pencil icon, edit mode should be activated.

Yes, thought about it as well, will do.

@Komediruzecki
Copy link
Contributor Author

Let's change a bit more. For the url, users need to click the url text to navigate.
Screen Shot 2022-03-28 at 4 56 02 PM
Users should click the red area to navigate to the url. If users click other than this area, including padding and the pencil icon, edit mode should be activated.

Yes, thought about it as well, will do.

@Rokt33r Added the change, its a bit of a hack since the property button is the parent of this element, so it's not easy to make it clickable to edit but also prevent opening URL, and otherwise impossible to put it outside of the property button, but preventing the clicking of URL.

So I've put it absolutely positioned on top, seems to be working nicely.

I've noticed that the link is being opened twice actually (not sure why), and if it's a known issue, it happens on Ubuntu.

@Rokt33r Rokt33r merged commit dd0aac0 into master Apr 13, 2022
@Rokt33r Rokt33r deleted the feature/fix-input-link-prop branch April 13, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants