fix: Implement ARIA Roles & Properties #144 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use ARIA-roles for dialog - Add focusmanagement to jump initial to cookie-dialog - Tested with chrome and edge (tried with Safari, however app even not rendered) Constraints: With Tab-Key it's still possible to leave modals, however this is a general bug in modals changelog: fixed
|
Preview deployed to https://3e09df20.academy-preview.pages.dev (total size: 15M) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Improve Accessibility for Cookie Dialog
Summary of Changes
• Implemented ARIA roles to enhance semantic accessibility of the cookie dialog.
• Added focus management to ensure initial focus jumps directly to the cookie dialog when displayed.
Testing
• Browser Testing:
• Successfully tested on Chrome and Edge.
• Attempted testing on Safari, but the app failed to render.
• Screen Reader Testing:
• Tested with VoiceOver on macOS.
Known Issues
• Users can navigate out of modals using the Tab key. This is a broader issue affecting all modals, unrelated to this specific PR.
• Limited ability to verify the accessibility of other dialogs due to lack of visual feedback. Suggesting collaboration, such as pair programming, to identify and address further accessibility gaps.
Related Issue
• Fixes bug #144