Skip to content

Bump BotBuilder SDK version to 4.21.0 #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Bump BotBuilder SDK version to 4.21.0 #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fec809
init
Danieladu Sep 20, 2023
be4a079
update
Danieladu Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CommonTargets/library.shared.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<Project>

<PropertyGroup>
<Bot_Builder_Version>4.13.1</Bot_Builder_Version>
<Bot_Builder_Preview_Version>4.13.0-rc5.preview</Bot_Builder_Preview_Version>
<Bot_Builder_Version>4.21.0</Bot_Builder_Version>
</PropertyGroup>

</Project>
2 changes: 1 addition & 1 deletion libraries/Bot.Builder.Community.Adapters.Google/Bot.Builder.Community.Adapters.Google.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1" />
<PackageReference Include="Microsoft.Extensions.Options" Version="2.1.1" />
<PackageReference Include="Microsoft.Net.Http.Headers" Version="2.1.1" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...uilder.Community.Adapters.Infobip.Core/Bot.Builder.Community.Adapters.Infobip.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PackageReference Include="Microsoft.Bot.Schema" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="2.1.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.1.0" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion libraries/Bot.Builder.Community.Adapters.Slack/Bot.Builder.Community.Adapters.Slack.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="SlackAPI" Version="1.1.12" />
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="$(Bot_Builder_Version)"/> </ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion ....Community.Components.Dialogs.Input/Bot.Builder.Community.Components.Dialogs.Input.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="AdaptiveCards" Version="2.7.1" />
<PackageReference Include="AdaptiveCards" Version="2.7.2" />
<PackageReference Include="Microsoft.Bot.Builder" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Declarative" Version="$(Bot_Builder_Version)" />
Expand Down
2 changes: 1 addition & 1 deletion ....Components.Handoff.ServiceNow/Bot.Builder.Community.Components.Handoff.ServiceNow.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="AdaptiveCards" Version="2.7.1" />
<PackageReference Include="AdaptiveCards" Version="2.7.2" />
<PackageReference Include="HtmlAgilityPack" Version="1.11.33" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.2.5" />
<PackageReference Include="Microsoft.Bot.Builder" Version="$(Bot_Builder_Version)" />
Expand Down
2 changes: 1 addition & 1 deletion ...es/Bot.Builder.Community.Components.Shared/Bot.Builder.Community.Components.Shared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PackageReference Include="Microsoft.Bot.Builder" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Microsoft.Bot.Schema" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.1.0" />
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.21" />
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.24" />
<PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion ...uilder.Community.Dialogs.Adaptive.Rest/Bot.Builder.Community.Dialogs.Adaptive.Rest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Bot.Builder.Dialogs.Adaptive" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.21" />
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.24" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion .../Bot.Builder.Community.Dialogs.ChoiceFlow/Bot.Builder.Community.Dialogs.ChoiceFlow.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion ...ries/Bot.Builder.Community.Dialogs.Location/Bot.Builder.Community.Dialogs.Location.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<ItemGroup>
<PackageReference Include="CoreCompat.System.Drawing" Version="1.0.0-beta006" />
<PackageReference Include="Microsoft.Bot.Builder.Dialogs" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...uilder.Community.Storage.Elasticsearch/Bot.Builder.Community.Storage.Elasticsearch.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<PackageReference Include="Microsoft.Bot.Builder" Version="$(Bot_Builder_Version)" />
<PackageReference Include="NEST" Version="7.6.1" />
<PackageReference Include="NEST.JsonNetSerializer" Version="7.6.1" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion ...er.Community.Storage.EntityFramework/Bot.Builder.Community.Storage.EntityFramework.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<PackageReference Include="Microsoft.Bot.Builder" Version="$(Bot_Builder_Version)" />
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="3.1.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="3.1.0" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion tests/Bot.Builder.Community.Adapters.Facebook.Tests/FacebookWrapperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void VerifySignatureShouldThrowErrorWithNullRequest()
[Fact]
public void VerifySignatureShouldReturnTrueWithValidRequestHash()
{
const string requestHash = "SHA1=70C0E1B415F16D986EB839144FC85A941A5899C7";
const string requestHash = "SHA1=32ECC29689D860D68A713FF5BA8D7B787C5E8C80";
var facebookWrapper = new FacebookClientWrapper(_testOptions);
var request = new Mock<HttpRequest>();
var stringifyBody = File.ReadAllText(Directory.GetCurrentDirectory() + @"/Files/RequestResponse.json");
Expand Down
2 changes: 1 addition & 1 deletion tests/Bot.Builder.Community.Adapters.Slack.Tests/SlackClientWrapperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void VerifySignatureShouldReturnTrue()
var httpRequest = new Mock<HttpRequest>();
httpRequest.Setup(req => req.Headers.ContainsKey(It.IsAny<string>())).Returns(true);
httpRequest.SetupGet(req => req.Headers["X-Slack-Request-Timestamp"]).Returns("0001-01-01T00:00:00+00:00");
httpRequest.SetupGet(req => req.Headers["X-Slack-Signature"]).Returns("V0=D213A711894A04CF10B2DAB9C6904436DCF1A7469E21C843BB4242E1F8E62EB0");
httpRequest.SetupGet(req => req.Headers["X-Slack-Signature"]).Returns("V0=CD482F6E327EB7B5882890614EB87CB20831C5A527CC4D419A3B3BCD4BC8761C");

Assert.True(slackApi.VerifySignature(httpRequest.Object, body));
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Bot.Builder.Community.Dialogs.Prompts.Tests/NumberWithUnit_PromptTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public async Task NumberWithUnitPrompt_Type_Currency()
.AssertReply("Bot received Value: 25, Unit: Dollar")
.Send("hello")
.AssertReply("Enter a currency.")
.Send("�50.5")
.Send("?0.5")
.AssertReply("Bot received Value: 50.5, Unit: Pound")
.StartTestAsync();
}
Expand Down