Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholders for new datapoints #140

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

kbabioch
Copy link
Collaborator

@kbabioch kbabioch commented Oct 2, 2023

This adds new parameters, calculations and visibilities as reported by the dump script after running it against a newly updated Luxtronik controller (3.89.1).

For now the meaning of those datapoints is not known, hence they are added as unknown.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py13410621%38–54, 61–66, 69–73, 79, 83, 102–113, 116–119, 122–142, 145–160, 163–180, 183–198, 202–204, 208–209, 213–214
   __main__.py21210%2–48
   datatypes.py2351295%37, 42, 47, 57, 72–75, 80–83, 92
   discover.py433421%25–77
luxtronik/scripts
   dump_changes.py44440%5–93
   dump_luxtronik.py28280%5–64
TOTAL58824558% 

Tests Skipped Failures Errors Time
110 4 💤 0 ❌ 0 🔥 0.962s ⏱️

@kbabioch kbabioch requested review from gerw, Bouni and BenPru October 2, 2023 08:39
This adds new parameters, calculations and visibilities as reported by
the dump script after running it against a newly updated Luxtronik
controller (3.89.1).

For now the meaning of those datapoints is not known, hence they are
added as unknown.
@kbabioch kbabioch force-pushed the feat/new-datapoints branch from a986e6d to 5ab5e42 Compare October 2, 2023 08:40
@kbabioch kbabioch merged commit eaadd76 into Bouni:main Oct 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants