Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff issues #182

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix ruff issues #182

merged 3 commits into from
Sep 20, 2024

Conversation

Bouni
Copy link
Owner

@Bouni Bouni commented Sep 20, 2024

I noticed that ruff was complaining after I merged a PR that was open for a few months, despite it was marked as all good in the PR view.

Probably som versin mismatch or something like that.

So I fixed the linter warnings and upgraded the pre-commit-cofig and the lint action.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py1841194%42–43, 46–51, 257–258, 263
   __main__.py21210%3–49
   datatypes.py276199%82
   discover.py403415%21–69
luxtronik/scripts
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
TOTAL67613680% 

Tests Skipped Failures Errors Time
124 0 💤 0 ❌ 0 🔥 3.999s ⏱️

@Bouni Bouni requested review from kbabioch and gerw September 20, 2024 10:40
Copy link
Collaborator

@gerw gerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerw gerw merged commit d0c3908 into main Sep 20, 2024
4 checks passed
@gerw gerw deleted the fix-ruff-issues branch November 1, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants