Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a KeyError exception if obsolete names are used #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Guzz-T
Copy link
Contributor

@Guzz-T Guzz-T commented Nov 20, 2024

Unlike #187, this version no longer supports obsolete names. Instead, it returns an exception, compelling the user to switch to the latest version.

The names are passed directly to the constructor, eliminating the need for additional files or constants. This allows for the identification of names from previous versions without the need to execute the code.

Fixes #168.
Replaces #171 and #187.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py1841194%42–43, 46–51, 257–258, 263
   __main__.py21210%3–49
   datatypes.py290199%110
   discover.py403415%21–69
luxtronik/scripts
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
TOTAL70213681% 

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 4.252s ⏱️

@Guzz-T
Copy link
Contributor Author

Guzz-T commented Dec 6, 2024

@Bouni, @gerw How do you like this proposed solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain a list of changed parameter/calculation names
1 participant