Core - Add last group hint when player re-jips in #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazing, both sound great |
TheCandianVendingMachine
requested changes
Jan 21, 2025
| @@ -40,6 +40,13 @@ private _return = if (_vehicle == _leader) then { | |||
| ["Teleporting to position", "No empty position for teleport"] select _success | |||
| } | |||
| } else { | |||
| [{ // hint if TP-to-Vic fails | |||
There was a problem hiding this comment.
(nitpick)
niche case, but if someone is fucking around in the start zone and enter a vehicle they won't have this pop
or if we add a shitty addon that for some reason makes this return an object
| params ["_player", "_profileName"]; | ||
| private _msg = if (_profileName in GVAR(playerMap)) then { | ||
| (GVAR(playerMap) get _profileName) params ["_lastSide", "_lastGroup"]; | ||
| private _sideText = ["?", "B", "O", "I"] select ([blufor, opfor, independent] find _lastSide); |
There was a problem hiding this comment.
civilian handling doesn't work, it will default to I since find == -1
There was a problem hiding this comment.
opps, I think there should have been a subtraction here, I'll just swap to a switch
| format ["has JIPed"]; | ||
| }; | ||
| INFO_2("playerConnected: %1: [%2]",_profileName,_msg); | ||
| if (CBA_missionTime < 60) exitWith {}; |
There was a problem hiding this comment.
future:
can probably set this timer to be the safe-start length as specified in the mission parameters option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds hint for player's last group when the jip in to make it faster and easier to get them back to where they should be
Remove time from admin log and moves it to tooltip