Unit Renaming #202
Open
Unit Renaming #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed several units to more accurate names. - Forward Air Controller (FAC) -> Joint Fires Observer (JFO) - Medium Machine Gun Spotter -> Medium Machine Gun Assistant Gunner - Medium AT Team Spotter -> Medium AT Team Assistant Gunner - Mortar Team Spotter -> Mortar Team Loader - Medium SAM Team Spotter -> Medium SAM Team Assistant Gunner *I noticed that the framework uses "loader" while the unit name is "assistant gunner". Should that be normalized to one name? I personally don't particularly mind tbh.
kil0byt3
approved these changes
Sep 18, 2024
|
#194 will need changes to match the new JFO slot, otherwise lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed several units to more accurate names.
*I noticed that the framework uses "loader" while the unit name is "assistant gunner". Should that be normalized to one name? I personally don't particularly mind tbh.