perf: validate len>0 for role check

BrackeysBot · Jul 21, 2023 · 334f85b · 334f85b
1 parent b3c6283
commit 334f85b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/SuggestionBot/Services/CooldownService.cs b/SuggestionBot/Services/CooldownService.cs
@@ -43,7 +43,9 @@ public TimeSpan GetRemainingCooldown(DiscordMember member)
         }
 
         ulong[] roleIds = member.Roles.Select(r => r.Id).ToArray();
-        if (configuration.CooldownExemptRoles.Any(roleIds.Contains))
+        ulong[] exemptRoleIds = configuration.CooldownExemptRoles;
+
+        if (roleIds.Length > 0 && exemptRoleIds.Length > 0 && exemptRoleIds.Any(roleIds.Contains))
         {
             return TimeSpan.Zero;
         }