Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMLABSBRN-2299 [BE & FrontEnd] Refactoring: merge controllers StudyH… #2302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Isink21
Copy link
Collaborator

@Isink21 Isink21 commented Sep 22, 2022

…istoryController and StudyHistoryControllerV2 into one class

EPMLABSBRN-XX

Description:

…istoryController and StudyHistoryControllerV2 into one class
@gitpod-io
Copy link

gitpod-io bot commented Sep 22, 2022

@github-actions
Copy link

Frontend test coverage: 95.45%

🤷‍♂️ Did not change

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Gradle Unit and Integration Test Results

446 tests  ±0   442 ✔️ ±0   58s ⏱️ -1s
107 suites  - 1       4 💤 ±0 
107 files    - 1       0 ±0 

Results for commit d78ba87. ± Comparison against base commit 20c4053.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ getHistories should return histories for period of time for user with role user()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ getHistories should return histories for period of time()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ isUserHasStatistics should return true when user has statistics for user with role user()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ isUserHasStatistics should return true when user has statistics()
com.epam.brn.integration.StudyHistoryControllerIT ‑ getHistories should return histories for period of time for user with role user()
com.epam.brn.integration.StudyHistoryControllerIT ‑ getHistories should return histories for period of time()
com.epam.brn.integration.StudyHistoryControllerIT ‑ isUserHasStatistics should return true when user has statistics for user with role user()
com.epam.brn.integration.StudyHistoryControllerIT ‑ isUserHasStatistics should return true when user has statistics()

@ElenaSpb ElenaSpb self-assigned this Sep 23, 2022
@ElenaSpb
Copy link
Contributor

This task is not only about backend - it is general task about front and back.
now this changes will broke the platform

so you need to find all usages of this end-points and change them too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants