Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add more edge cases #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: add more edge cases #42

wants to merge 1 commit into from

Conversation

araujo88
Copy link
Member

@araujo88 araujo88 commented Jan 5, 2025

Description

Add more tests that cover edge cases for ints, floats and doubles.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have documented my changes in the code or documentation
  • I have added tests that prove my changes work (if applicable)
  • All new and existing tests pass

@VeryElegantBread
Copy link
Contributor

In division_edge_cases.brainrot it says 1.0 / 0.0 should return inf. 1 / 0 should error, not return infinite.

@araujo88
Copy link
Member Author

araujo88 commented Jan 5, 2025

In division_edge_cases.brainrot it says 1.0 / 0.0 should return inf. 1 / 0 should error, not return infinite.

We might handle this case similar to how javascript does or keep it consistent with how C does.

@araujo88 araujo88 force-pushed the feat/edge-test-cases branch from eeb15be to 0efb42c Compare January 7, 2025 03:39
@araujo88 araujo88 added the tests Testing examples and edge cases label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing examples and edge cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants