-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yin Yang Puzzle #876
Merged
Merged
Yin Yang Puzzle #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial Minesweeper implementation work
Add Unset tile type
Created initial classes for bomb, flag, utilities, and contradiction rule.
This reverts commit 89fbe94.
This reverts commit ace7122.
Changes are well-contained within the Minesweeper classes and don't appear to create any conflicts. No puzzle files yet to test UI changes. Compilation tests pass. Merging
removed fillapix imports
Added the unset puzzle element, added the minesweeper board copy function, fixed the bomb or filled case rule
This reverts commit ace7122.
# Conflicts: # src/main/resources/edu/rpi/legup/legup/config
Added helper functions used for getting cells adjacent to flag, as well as combinations of possible bomb tiles.
Co-Authored-By: sdhoat <[email protected]>
Co-Authored-By: sdhoat <[email protected]>
Co-Authored-By: sdhoat <[email protected]>
Co-Authored-By: sdhoat <[email protected]>
Co-Authored-By: sdhoat <[email protected]>
Co-Authored-By: sdhoat <[email protected]>
Co-Authored-By: sdhoat <[email protected]>
Co-Authored-By: sdhoat <[email protected]>
some small improvements and comments
New rule isolatemine - a mine must see a number cell. Added the rule and test suite for the rule.
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Minesweeper changes
Updated puzzles to add persistent tags, hashed the exported solved state of the board, and updated batch grader to new format
Minesweeper rules, test suite, and bug fixes
jadeandtea
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I based the branch off of master, so this merges all of dev into the branch as well, which all is fine. The YinYang code style is fine, but might be unstable so it's getting merged into a feature branch first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet functional as we haven't created the executable puzzle files. However, every required file is mostly implemented and there are no errors in the code, although there likely might be bugs as we never got to actually testing the puzzle.