Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yin Yang Puzzle #876

Merged
merged 155 commits into from
Jan 11, 2025
Merged

Yin Yang Puzzle #876

merged 155 commits into from
Jan 11, 2025

Conversation

andrewtarnavsky
Copy link
Collaborator

@andrewtarnavsky andrewtarnavsky commented Jan 11, 2025

Not yet functional as we haven't created the executable puzzle files. However, every required file is mostly implemented and there are no errors in the code, although there likely might be bugs as we never got to actually testing the puzzle.

FisherLuba and others added 30 commits January 27, 2024 21:29
Initial Minesweeper implementation work
Created initial classes for bomb, flag, utilities, and contradiction rule.
This reverts commit 89fbe94.
This reverts commit ace7122.
Changes are well-contained within the Minesweeper classes and don't appear to create any conflicts. No puzzle files yet to test UI changes. Compilation tests pass. Merging
removed fillapix imports
Added the unset puzzle element, added the minesweeper board copy function, fixed the bomb or filled case rule
This reverts commit ace7122.
# Conflicts:
#	src/main/resources/edu/rpi/legup/legup/config
Added helper functions used for getting cells adjacent to flag, as well as combinations of possible bomb tiles.
andrewtarnavsky and others added 26 commits December 6, 2024 19:09
Co-Authored-By: sdhoat <[email protected]>
some small improvements and comments
New rule isolatemine - a mine must see a number cell. Added the rule and test suite for the rule.
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Co-Authored-By: andrewtarnavsky <[email protected]>
Updated puzzles to add persistent tags, hashed the exported solved state of the board, and updated batch grader to new format
Minesweeper rules, test suite, and bug fixes
@jadeandtea jadeandtea self-requested a review January 11, 2025 02:32
@andrewtarnavsky andrewtarnavsky changed the base branch from dev to YinYang January 11, 2025 03:00
Copy link
Collaborator

@jadeandtea jadeandtea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I based the branch off of master, so this merges all of dev into the branch as well, which all is fine. The YinYang code style is fine, but might be unstable so it's getting merged into a feature branch first.

@jadeandtea jadeandtea merged commit 6edbbb5 into Bram-Hub:YinYang Jan 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.