Updated generateShortLinkSync and test

BranchMetrics · Jul 18, 2023 · e291670 · e291670
1 parent 86fca0e
commit e291670
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 25 deletions.
diff --git a/Branch-SDK/src/androidTest/java/io/branch/referral/BranchApiTests.java b/Branch-SDK/src/androidTest/java/io/branch/referral/BranchApiTests.java
@@ -73,7 +73,7 @@ public void run() {
     @Test
     public void test00GetShortUrlSyncFailure() {
         String url = new BranchShortLinkBuilder(getTestContext()).getShortUrl();
-        Assert.assertNull(url);
+        Assert.assertNotNull(url);
     }
 
     @Test

diff --git a/Branch-SDK/src/main/java/io/branch/referral/Branch.java b/Branch-SDK/src/main/java/io/branch/referral/Branch.java
@@ -1662,35 +1662,27 @@ public void cancelShareLinkDialog(boolean animateClose) {
     // PRIVATE FUNCTIONS
 
     private String generateShortLinkSync(ServerRequestCreateUrl req) {
-        if (trackingController.isTrackingDisabled()) {
-            return req.getLongUrl();
+        ServerResponse response = null;
+        try {
+            int timeOut = prefHelper_.getTimeout() + 2000; // Time out is set to slightly more than link creation time to prevent any edge case
+            response = new GetShortLinkTask().execute(req).get(timeOut, TimeUnit.MILLISECONDS);
+        } catch (InterruptedException | ExecutionException | TimeoutException ignore) {
+        }
+        String url = null;
+        if (req.isDefaultToLongUrl()) {
+            url = req.getLongUrl();
         }
-        if (initState_ == SESSION_STATE.INITIALISED) {
-            ServerResponse response = null;
+        if (response != null && response.getStatusCode() == HttpURLConnection.HTTP_OK) {
             try {
-                int timeOut = prefHelper_.getTimeout() + 2000; // Time out is set to slightly more than link creation time to prevent any edge case
-                response = new GetShortLinkTask().execute(req).get(timeOut, TimeUnit.MILLISECONDS);
-            } catch (InterruptedException | ExecutionException | TimeoutException ignore) {
-            }
-            String url = null;
-            if (req.isDefaultToLongUrl()) {
-                url = req.getLongUrl();
-            }
-            if (response != null && response.getStatusCode() == HttpURLConnection.HTTP_OK) {
-                try {
-                    url = response.getObject().getString("url");
-                    if (req.getLinkPost() != null) {
-                        linkCache_.put(req.getLinkPost(), url);
-                    }
-                } catch (JSONException e) {
-                    e.printStackTrace();
+                url = response.getObject().getString("url");
+                if (req.getLinkPost() != null) {
+                    linkCache_.put(req.getLinkPost(), url);
                 }
+            } catch (JSONException e) {
+                e.printStackTrace();
             }
-            return url;
-        } else {
-            PrefHelper.Debug("Warning: User session has not been initialized");
         }
-        return null;
+        return url;
     }
 
     private JSONObject convertParamsStringToDictionary(String paramString) {