Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:SDK-2025 -- [Android] Remove unused code #1085

Merged
merged 11 commits into from
Jul 31, 2023

Conversation

gdeluna-branch
Copy link
Contributor

@gdeluna-branch gdeluna-branch commented Jul 20, 2023

Reference

SDK-2025 -- [Android] Remove unused code

Description

Removing more code that has fallen into disuse.

Testing Instructions

Run through a test app, especially opening and closing as we're removing the post. No behavior should change.

Risk Assessment [LOW]

  • [✅] I, the PR creator, have tested — integration, unit, or otherwise — this code.

Reviewer Checklist (To be checked off by the reviewer only)

  • JIRA Ticket is referenced in PR title.
  • Correctness & Style
    • Conforms to AOSP Style Guides
    • Mission critical pieces are documented in code and out of code as needed.
  • Unit Tests reviewed and test issue sufficiently.
  • Functionality was reviewed in QA independently by another engineer on the team.

cc @BranchMetrics/saas-sdk-devs for visibility.

@gdeluna-branch gdeluna-branch changed the title fix:Remove unused code fix:SDK-2025 -- [Android] Remove unused code Jul 25, 2023
@gdeluna-branch gdeluna-branch marked this pull request as ready for review July 25, 2023 20:54
@gdeluna-branch gdeluna-branch merged commit 919b360 into master Jul 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants