-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2329] Added apiUrl check in BranchJSONConfig #1183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
============================================
+ Coverage 38.24% 38.28% +0.03%
- Complexity 687 690 +3
============================================
Files 59 59
Lines 6309 6327 +18
Branches 944 946 +2
============================================
+ Hits 2413 2422 +9
- Misses 3448 3455 +7
- Partials 448 450 +2 ☔ View full report in Codecov by Sentry. |
gdeluna-branch
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2329 -- Support setting Branch API URL in Branch.json
Description
Added a new field to branch.json for setting the Branch API URL. The config check and setAPIUrl call are done in the getAutoInstance in the same place as the deferInitForPluginRuntime() check.
One quirk is that all of the base URL's are stored with a "/" at the end, so we need to add that to the provided URL when making the setAPIUrl call. We don't want to have a URL ending with a "/" in the branch.json itself though since on iOS, the base URLs are stored without the "/".
Testing Instructions
Add
"apiUrl": "https://api.branch.io"
to a branch.json file and observe the API URL properly change for each request.Risk Assessment [
LOW
]Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.