Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Installation Tests Android #1186

Closed

Conversation

NidhiDixit09
Copy link
Contributor

Reference

QSS-112 - Reinstallation Scenario
https://branch.atlassian.net/browse/QSS-112

Description

For testing Reinstallation Scenario, added following in Android Automation Test Bed app:
-- Init Session Button : On click of this button, Branch session force initialized
-- Read Logs Button: On click of this button, Log Window is opened, which prints Branch SDK Logs

Testing Instructions

Manually build and run app and verify new buttons are working as described above.

Risk Assessment [HIGH || MEDIUM || LOW]

LOW

  • [ X] I, the PR creator, have tested — integration, unit, or otherwise — this code.

Reviewer Checklist (To be checked off by the reviewer only)

  • [X ] JIRA Ticket is referenced in PR title.
  • Correctness & Style
    • [X ] Conforms to AOSP Style Guides
    • [ X] Mission critical pieces are documented in code and out of code as needed.
  • Unit Tests reviewed and test issue sufficiently.
  • Functionality was reviewed in QA independently by another engineer on the team.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.11%. Comparing base (69cd050) to head (7434846).

Additional details and impacted files
@@                         Coverage Diff                         @@
##             SDK-2228-DMA-Automation-Tests    #1186      +/-   ##
===================================================================
+ Coverage                            38.04%   38.11%   +0.06%     
- Complexity                             686      689       +3     
===================================================================
  Files                                   59       59              
  Lines                                 6279     6279              
  Branches                               939      939              
===================================================================
+ Hits                                  2389     2393       +4     
+ Misses                                3444     3443       -1     
+ Partials                               446      443       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Branch.getInstance().setIdentity("automation_test_user");
}
Branch.enableLogging();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if/else enables logging no matter what, may as well keep it here

@ahmednawar
Copy link

@NidhiDixit09 what's next for this PR? It has been open for almost 2 months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants