[SDK-2384] Add BranchLogLevel for setting minimum logging level #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BranchLogger.logAlways(GOOGLE_VERSION_TAG); | ||
| BranchLogger.setLoggingEnabled(true); | ||
| public static void enableLogging(IBranchLoggingCallbacks iBranchLogging) { | ||
| enableLogging(iBranchLogging, BranchLogger.BranchLogLevel.DEBUG); |
There was a problem hiding this comment.
Does this mean customers using this feature will no longer produce logs for VERBOSE by default? This will break those workflows.
If it's not set, the original behavior should be maintained.
There was a problem hiding this comment.
This could also break our own automation tests.
There was a problem hiding this comment.
Updated it to set logs to Verbose when using a callback.
gdeluna-branch
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2384 -- Add setting log levels to BranchLogger
Description
Add a new way to set the minimum log level in the BranchLogger class by creating BranchLogLevel. This allows us to add log level checks throughout the SDK and gives clients the ability to reduce logs if desired.
Testing Instructions
Call the new enabledLogging methods with the various BranchLogLevels and observe that only the correct logs are appearing.
Risk Assessment [
LOW]Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.